Conversation
|
Please review, thanks! |
|
please review |
| "Present" => "Presente", | ||
| "Excluding {days}" => "Exceto {days}", | ||
| ], | ||
| "ro_cuDiacritice" => [ |
There was a problem hiding this comment.
Any reason to call this ro_cuDiacritice instead of ro for simplicity? Would there need to be other versions of Romanian supported separately?
| "ro_cuDiacritice" => [ | |
| "ro" => [ |
There was a problem hiding this comment.
@CristinaEU1 this is failing the CI test:
Locale 'ro_cuDiacritice' is not normalized. Expected 'ro'.
There was a problem hiding this comment.
Yes, currently the script expects the locale to have a language code (2 to 3 letters), optionally followed by a script code (4 letters), optionally followed by a region code (2 letters or 3 numbers), for example, "ro", "ro_RO", "ro_MD" are options, sometimes we use scripts like "zh_Hans" to differentiate from "zh_Hant", but in general we only specify region and script if it's not the "typical" for this language. We can change the normalization if we need to, but in this case, I think Romanian should just be "ro" because (as far as I know) we won't need to implement a version of Romanian without diacritice.
https://github.com/DenverCoder1/github-readme-streak-stats/blob/main/src%2Fcard.php#L265
|
Romanian support was merged in #874 |
3 participants
Added Romanian language with native Romanian letters
Description
Fixes #
Type of change
How Has This Been Tested?
composer testChecklist:
Screenshots